Skip to content

Bugfix for losing autoFilter with multiple sheets #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2023
Merged

Bugfix for losing autoFilter with multiple sheets #191

merged 1 commit into from
Jun 2, 2023

Conversation

heew
Copy link
Contributor

@heew heew commented Mar 15, 2018

Fixes issue #190

lion2486
lion2486 approved these changes Apr 30, 2018
View reviewed changes
Copy link

@lion2486 lion2486 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks at first sign to be a reasonable one. Maybe the count($this->sheets) will get the same number but it's a quick fix.
Tested on my own and it works.

@hnx8 hnx8 mentioned this pull request Jul 6, 2018
Open
@hnx8
Copy link

hnx8 commented Jul 6, 2018

I noticed when I was doing enhancement, as far as seeing the contents of the actual Xlsx file,
it seems more appropriate that the "localSheetId" are numbered in order from the first sheet, regardless of whether AutoFilter is specified or not.
(so, in # 207 I fixed it in a form that seemed better)

@mk-j mk-j merged commit 5b77d3d into mk-j:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lion2486 lion2486 lion2486 approved these changes

@mk-j mk-j mk-j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heew @hnx8 @lion2486 @mk-j