-
Notifications
You must be signed in to change notification settings - Fork 162
Trajectory Generation V2 #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
- Coverage 85.51% 85.35% -0.16%
==========================================
Files 78 83 +5
Lines 6867 7445 +578
==========================================
+ Hits 5872 6355 +483
- Misses 995 1090 +95 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
GUI
Changes to the PathPlanner GUI
PathPlannerLib
Changes to PathPlannerLib
workflows
Changes to the GitHub Actions workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of the trajectory generation to properly balance robot rotation and translation, and respect individual module limits. This isn't time optimal like Choreo, but should be significantly more accurate and hopefully allow PathPlanner paths to "just work" with little to no path tuning.
Still has a lot of issues that need to be ironed out and optimizations that need to be made. Some of these issues are due to the distribution of path samples along each spline segment. These will be fixed in a future PR that will dynamically sample the path based on distance and amount of rotation. Should be good enough for now with future PRs to improve it.
DocumentationWill do later to get this merged sooner