Skip to content

Conversation

@KennanHunter
Copy link
Contributor

@KennanHunter KennanHunter commented Apr 4, 2024

I created a new method called buildAutoChooserWithOptionsModifier, that accepts a second parameter in the form of a lambda function that takes in a stream and returns a stream of PathPlannerAutos.

I also added documentation to filter these options based on if they included the text "comp" at the beginning of the name. Some other examples you could do would be override the name with .setName, filter depending on if you're red or blue, or use .sorted() on the stream to sort them arbitrarily before going on shuffle board.

I couldn't run spotless for some weird errors in my environment I need to figure out but the formatting should be good enough. I also manually wrote that documentation so no guarantees it actually works with Writerside 🤷.

P.S. pathplanners great, thanks for all the work you do :)

@github-actions github-actions bot added PathPlannerLib Changes to PathPlannerLib documentation Pull requests that update the documentation site files labels Apr 4, 2024
@mjansen4857
Copy link
Owner

/format

@mjansen4857
Copy link
Owner

mjansen4857 commented Apr 4, 2024

Well format bot is broken so that's unfortunate

Edit: I have no idea if this is how it works since I yoinked it from WPILib, but it may work if you do it? If not, you can try opening pplib in intellij, its usually pretty good with gradle projects.

@KennanHunter
Copy link
Contributor Author

/format

@KennanHunter
Copy link
Contributor Author

It looks like the format bot is trying to branch origin/main and doesn't know how to merge it up onto the pr... not exactly sure how thats supposed to work.

@mjansen4857
Copy link
Owner

Yeah. It seems to work for some people but not others for whatever reason.

@github-actions github-actions bot added the workflows Changes to the GitHub Actions workflows label Apr 4, 2024
@mjansen4857
Copy link
Owner

That workflow dispatch change wouldn't work since the workflow is very specific to comments

@KennanHunter
Copy link
Contributor Author

KennanHunter commented Apr 4, 2024

Whoops, those still didn't work. I'm going to revert those because I didn't realize they would get put in this pr immediately.

@github-actions github-actions bot removed the workflows Changes to the GitHub Actions workflows label Apr 4, 2024
@mjansen4857 mjansen4857 merged commit 05a123d into mjansen4857:main Apr 7, 2024
@tbeadle
Copy link

tbeadle commented Apr 14, 2024

@mjansen4857 any idea when a release will be cut with this change in it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests that update the documentation site files PathPlannerLib Changes to PathPlannerLib

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants