dune: enable generate_opam_files option #523
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smorimoto
force-pushed
the
enable-generate-opam-files
branch
from
434d925 to
e7db5b9
Compare
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
force-pushed
the
enable-generate-opam-files
branch
from
980d4cf to
3569ffe
Compare
|
what is the motivation for this PR? I appreciate the CI fixes, which could be a separate PR. But the generate_opam_file, I'm rather hesitant unless there's a clear motivation. Now, you don't even provide a description, so I have to ask. |
|
Today I had to debug this package, and since I've been using dune pkg lately, I tried to bootstrap the project using it, but it complained so I moved it to the dune-based workflow as much as possible. If it's OK, you can merge it, or if you're not interested, you can close! Then, of course I can separate the CI fix into another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.