fix: explicitly use UTC for expiration field when marshaling PostPolicy #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #2134, namely that non-UTC values of
PostPolicy.expirationwere being formatted into incorrect timestamps when marshaling to JSON.No test cases were added for this change as no tests currently exist at all for
PostPolicy.String()orPostPolicy.marshalJSON(). I think if test cases were to be added, however, it might be appropriate to turn the constantexpirationDateFormatinto a function or receiver such asfunc formatExpirationDate(time.Time) stringand directly test the result of that, rather than testingmarshalJSON()as a whole. Let me know if that'd be appreciated.