-
Notifications
You must be signed in to change notification settings - Fork 272
Fix up image workloads #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up image workloads #1478
Conversation
Signed-off-by: Troy Dawson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please give me a chance to review changes first.
@@ -29,7 +29,6 @@ data: | |||
- dnf-utils | |||
- dracut-config-generic | |||
- e2fsprogs | |||
- efibootmgr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
efibootmgr should be included but only for UEFI arches (x86_64 and aarch64).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is included on x86_64 and aarch64. But when I moved it down there, I forgot to remove it from the overall group.
@@ -29,7 +29,6 @@ data: | |||
- dnf-utils | |||
- dracut-config-generic | |||
- e2fsprogs | |||
- efibootmgr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto here.
Please trust me to do simple changes without you. |
Sorry, that came out with the wrong tone. |
The HA image still needs a fix though. fence-agents is one of those tricky packages which is a placeholder in ELN but is also a real package in Fedora and when listed in a workload (e.g. Extras, or here) it gets pulled in. HA is one area where things aren't so clean atm, see fedora-eln/eln#229. Maybe the HA image configs should be CS only? |
I'm good with the HA image being CS only. I think that is the cleanest way. |
There were several warnings from the original workloads. This fixes those.