Skip to content

Conversation

tdawson
Copy link
Collaborator

@tdawson tdawson commented Aug 13, 2025

There were several warnings from the original workloads. This fixes those.

Signed-off-by: Troy Dawson <[email protected]>
@tdawson tdawson merged commit a023d5e into minimization:main Aug 13, 2025
1 check passed
Copy link
Collaborator

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give me a chance to review changes first.

@@ -29,7 +29,6 @@ data:
- dnf-utils
- dracut-config-generic
- e2fsprogs
- efibootmgr
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

efibootmgr should be included but only for UEFI arches (x86_64 and aarch64).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is included on x86_64 and aarch64. But when I moved it down there, I forgot to remove it from the overall group.

@@ -29,7 +29,6 @@ data:
- dnf-utils
- dracut-config-generic
- e2fsprogs
- efibootmgr
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here.

@tdawson
Copy link
Collaborator Author

tdawson commented Aug 13, 2025

Please give me a chance to review changes first.

Please trust me to do simple changes without you.

@tdawson
Copy link
Collaborator Author

tdawson commented Aug 13, 2025

Please give me a chance to review changes first.

Please trust me to do simple changes without you.

Sorry, that came out with the wrong tone.
I'm trying to save you time by doing things pro-actively. But if you then have to come back and double check everything I do, then I haven't really saved you any time.
If this wasn't something I was comfortable with, I wouldn't have merged it.

@yselkowitz
Copy link
Collaborator

The HA image still needs a fix though. fence-agents is one of those tricky packages which is a placeholder in ELN but is also a real package in Fedora and when listed in a workload (e.g. Extras, or here) it gets pulled in. HA is one area where things aren't so clean atm, see fedora-eln/eln#229. Maybe the HA image configs should be CS only?

@tdawson
Copy link
Collaborator Author

tdawson commented Aug 14, 2025

I'm good with the HA image being CS only. I think that is the cleanest way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants