Remove binstubs options from defaults#219
Merged
gabskoro merged 1 commit intomina-deploy:masterfrom Aug 28, 2014
lucapette:remove_binstubs
Merged
Remove binstubs options from defaults#219gabskoro merged 1 commit intomina-deploy:masterfrom lucapette:remove_binstubs
gabskoro merged 1 commit intomina-deploy:masterfrom
lucapette:remove_binstubs
Conversation
gabskoro
added a commit
that referenced
this pull request
Aug 28, 2014
Remove binstubs options from defaults
Contributor
Author
|
oh that was fast! Thank you for merging it! |
|
This is fine and all, I understand the rationale re: Rails 4, but this should not have been published in a patch-level update (0.3.1). My god scripts have been calling the release's bin/unicorn and I just had a site die on me during a deployment because of that. mina/god/unicorn is my zero-downtime solution, it sucks to have a tool surprise me and cause a failure like that. If it was even a minor version update then it would have been my own fault for not checking the changelog, but of course I have mina locked to "~> 0.3.0". Anyway just giving you a heads-up. It's easy to forget that "public API" includes more than just Ruby methods. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #162