Merged
Conversation
Member
|
Thank you for cleaning up our mess! :) |
Member
|
...and thank you for putting tests in there as well. @mikong this is clear with me. :-) |
mikong
added a commit
that referenced
this pull request
Jun 7, 2012
Check Git if empty, gitignore pkg, and fix deploy script template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, i did a bunch of small improvements.
Also, i encountered the problem if you try to run deploy outside of git tree. Im using mina to run automated deployments, so on my side there are no git repositories or project files, basically running it in headless mode. My change fixes that issue.
Test is included.