@milesburton Reveretd int16_t back to int8_t due to microcontroller r…#224
Merged
milesburton merged 2 commits intomasterfrom Jul 5, 2022
Merged
@milesburton Reveretd int16_t back to int8_t due to microcontroller r…#224milesburton merged 2 commits intomasterfrom
milesburton merged 2 commits intomasterfrom
Conversation
…esource constraints
Owner
Author
|
@RobTillaart If time permits would you mind sanity checking this PR? |
Contributor
|
OK, but it will be later this week I expect. Have several issues in progress in my own libraries already. |
Owner
Author
|
No problem Rob. Whenever you get time, appreciate you're a busy man.
…On Tue, 5 Jul 2022 at 11:02, Rob Tillaart ***@***.***> wrote:
OK, but it will be later this week I expect. Have several issues in
progress in my own libraries already.
—
Reply to this email directly, view it on GitHub
<#224 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJGHMZ5DWZ5RTRI5Y2MSTLVSQB45ANCNFSM52VEGUVA>
.
You are receiving this because you authored the thread.Message ID:
<milesburton/Arduino-Temperature-Control-Library/pull/224/c1174872454@
github.com>
|
Contributor
|
I see, it are only two files, they are OK. What is missing is an update of the version number in library.properties. |
…esource constraints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…esource constraints