Skip to content

dev -> main#1522

Merged
mikepenz merged 2 commits intomainfrom
develop
Mar 1, 2026
Merged

dev -> main#1522
mikepenz merged 2 commits intomainfrom
develop

Conversation

@mikepenz
Copy link
Copy Markdown
Owner

@mikepenz mikepenz commented Mar 1, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 1, 2026 18:21
@mikepenz mikepenz added the ignore label Mar 1, 2026
@mikepenz mikepenz merged commit a34a800 into main Mar 1, 2026
11 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 1, 2026

TestsPassed ✅SkippedFailed
JUnit Test Report67 ran67 passed0 skipped0 failed
TestResult
No test annotations available

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates JavaScript/TypeScript tooling and rebuilds the packaged dist/ artifacts for the GitHub Action, primarily by bumping dependency versions in package.json/package-lock.json.

Changes:

  • Bump semver and multiple dev toolchain packages (ESLint, TypeScript-ESLint, Node types, globals).
  • Regenerate dist/index.js and dist/licenses.txt based on the updated dependency graph.
  • Add .npmrc to force npm to ignore peer dependency conflicts during install.

Reviewed changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Dependency/devDependency version bumps (notably ESLint major upgrade).
package-lock.json Lockfile regeneration reflecting updated dependency tree.
dist/index.js Rebuilt bundled action output via ncc (module IDs/externals changed; includes minor comment text fixes).
dist/licenses.txt Updated third-party license aggregation after rebuild.
.npmrc Adds legacy-peer-deps=true impacting installation behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +60 to 63
"eslint": "^10.0.2",
"eslint-import-resolver-typescript": "^4.4.4",
"eslint-plugin-github": "^6.0.0",
"eslint-plugin-import": "^2.32.0",
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-plugin-github@6.0.0 declares a peer dependency of eslint as ^8 || ^9 (see package-lock.json around the eslint-plugin-github entry). This PR bumps eslint to ^10.0.2 and then adds legacy-peer-deps=true to force installation anyway, which risks broken linting/runtime errors and makes installs non-deterministic across npm versions. Please either upgrade eslint-plugin-github (and any other plugins) to versions that support ESLint v10, or keep ESLint on a supported major version, and remove the legacy-peer-deps workaround.

Copilot uses AI. Check for mistakes.
"@types/node": "^25.1.0",
"@eslint/eslintrc": "^3.3.4",
"@eslint/js": "^10.0.1",
"@types/eslint-scope": "^9.1.0",
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/eslint-scope is a deprecated stub package (eslint-scope ships its own types). Adding it as a direct devDependency is likely unnecessary and can cause confusing/incorrect type resolution. Please remove this dependency unless you have a concrete TypeScript error that requires it, and prefer relying on the types bundled with eslint-scope/ESLint.

Suggested change
"@types/eslint-scope": "^9.1.0",

Copilot uses AI. Check for mistakes.
@@ -0,0 +1 @@
legacy-peer-deps=true
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting legacy-peer-deps=true makes npm ignore peer dependency conflicts (and can mask real dependency incompatibilities). In this PR it appears to be used to bypass an ESLint v10 peer-dependency mismatch, which is better fixed by aligning package versions. Please remove this and resolve the underlying peer dependency issues instead.

Suggested change
legacy-peer-deps=true
; .npmrc intentionally left without legacy-peer-deps overrides

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants