Skip to content

Introduce fetchViaCommits configuration | Offers a new feature to solve an edge case resulting in old PRs not being included in changelog for squash merges#1180

Merged
mikepenz merged 6 commits intodevelopfrom
fix/1176
Jul 28, 2023
Merged

Introduce fetchViaCommits configuration | Offers a new feature to solve an edge case resulting in old PRs not being included in changelog for squash merges#1180
mikepenz merged 6 commits intodevelopfrom
fix/1176

Conversation

@mikepenz
Copy link
Owner

@mikepenz mikepenz commented Jul 28, 2023

  • honor authorDate and commitDate seperatly when detecting the PR date range to consider
  • use the right commit for from date
  • introduce new getForCommitHash to retrieve PRs based on hashes
  • reorganize pull request filtering -> if we get PRs from commit hash, open PRs are already included, neither filtering is
  • significantly simplify logic for results from commit hashes (only deduping needed) + filter if we don't want open PRs
  • introduce new configuration fetchViaCommits which is best suited for environments with shorter diffs and/or squash merging (1 api request per commit)
  • update tests for new configuration option

  - FIX #1176
- honor authorDate and commitDate seperatly when detecting the PR date range to consider
@mikepenz mikepenz added the fix label Jul 28, 2023
mikepenz added 5 commits July 28, 2023 07:49
- reorganize pull request filtering -> if we get PRs from commit hash, open PRs are already included, neither filtering is needed
- significantly simplify logic for results from commit hashes (only deduping needed) + filter if we don't want open PRs
…for environments with shorter diffs and/or squash merging (1 api request per commit)
@mikepenz mikepenz changed the title Fix edge case resulting in old PRs not being included in changelog for squash merges Introduce fetchViaCommits configuration | Offers a new feature to solve an edge case resulting in old PRs not being included in changelog for squash merges Jul 28, 2023
@mikepenz mikepenz removed the fix label Jul 28, 2023
@mikepenz mikepenz merged commit 45856fd into develop Jul 28, 2023
@mikepenz mikepenz deleted the fix/1176 branch July 28, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant