Add number in the list of properties supported for rules#1091
Add number in the list of properties supported for rules#1091mikepenz merged 5 commits intomikepenz:developfrom zaphiro-technologies:add-pr-number-#1079
number in the list of properties supported for rules#1091Conversation
mikepenz
left a comment
mikepenz
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution!
mikepenz
changed the title
number in the list of properties supported for rulesnumber in the list of properties supported for rules
| }) | ||
|
|
||
|
|
||
| it('Use Rules to get current open PR and merged categorised.', async () => { |
There was a problem hiding this comment.
@mikepenz thanks for your support!
I have the feeling I am doing something wrong.... to check if the rules works correctly, i added a test. it seems that rules are combined with and logic and due to that, no output is generated in this case.
There was a problem hiding this comment.
ps: sorry that my linter messed up :(
There was a problem hiding this comment.
@mikepenz to solve the issue, I introduced an additional configuration that allows to define whether rules are exclusive or not: category.exclusive_rules. When this value is not set, to guarantee backward compatibility, it is set to the same value as category.exhaustive.
I locally run tests, and all passes, including the one i defined.
|
Thank you very much for the contribution. Decided to rename |
Thank you for accepting my contribute! |
2 participants
fixes #1079