Executing a file with a relative path on Windows is broken

[angrybrad]

If I pass in a relative path on Windows to execute (assuming what I want to execute is already in the working directory or in my PATH environment variable), it produces incorrect output.

For example:

mysqldump --defaults-extra-file=C:\temp\my.cnf --add-drop-table --comments --create-options --dump-date --no-autocommit --routines --set-charset --triggers --result-file=C:\temp\backup.sql testdatabase

Will produce:

cd "mysqldump --defaults-extra-file=C:\temp\my.cnf --add-drop-table --comments --create-options --dump-date --no-autocommit --routines --set-charset --triggers --result-file=C:\temp" && backup.sql testdatabase

It looks like d9a0e8e is really only a fix for absolute paths.

[angrybrad]

Related pull request: #23

[angrybrad]

Thoughts on this one?

[mikehaertl]

@takobell Ouch, I'm sorry. I was confused about the new "Start a review" feature on Github and just found out, that I had to submit my comments first before you can see it. It was lingering there for month.

[angrybrad]

@mikehaertl No worries... still getting used to the new review tools myself.

[mikehaertl]

Just release 1.2.5 containing your fix. Thanks for your help!