Ensure PIL.Image.resize() always gets a tuple size #2248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Relevant discussion is in python-pillow/Pillow#8195. |
Contributor
Author
|
It looks like Pillow is planning to allow |
Owner
|
Thanks for the fix!! Seems like we might as well stick with a tuple even if they re-enable this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2247.
I found these by grepping for
\bresize\band then auditing the context to decide whether the argument could be something other than a tuple. (I did not check whether every change here corresponds to a particular test regression.)Then I repeated the tests as described in #2247 (comment) and confirmed that this fixes all of the regressions I reported, and doesn’t cause any new regressions.