Closed
Conversation
miguelmarcondesf
force-pushed
the
sqlite-db-options
branch
from
5cd07eb to
1aca01e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new SQLite database options to allow users to control how integers are read and how query parameters are handled. Key changes include:
- Adding tests for new options (readBigInts, returnArrays, allowBareNamedParameters, and allowUnknownNamedParameters) in the test suite.
- Implementing new inline getter/setter methods and member variables in the C++ source to support these options.
- Updating environment properties and API documentation to reflect the new configuration options.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/parallel/test-sqlite-database-sync.js | Added tests verifying correct option types and behaviors. |
| src/node_sqlite.h | Introduced inline methods and new member variables for options. |
| src/node_sqlite.cc | Updated option parsing and assignment in the DatabaseSync ctor. |
| src/env_properties.h | Added new property strings for the new options. |
| doc/api/sqlite.md | Updated docs to include the descriptions of the new options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.