Closed
Conversation
miguelmarcondesf
force-pushed
the
performance-improvements-sourcemap
branch
2 times, most recently
from
d892e53 to
3f13a91
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves the performance of source map operations by refactoring the source map parser to use destructuring for improved clarity and efficiency, and by updating benchmark tests and documentation accordingly.
- Refactor of source map parsing in lib/internal/source_map/source_map.js to destructure map properties.
- Update of benchmark documentation paths and benchmark test files.
- Renaming update in benchmark/es/error-stack.js for clearer operation naming.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/internal/source_map/source_map.js | Refactored source map parsing with destructuring to improve performance. |
| doc/contributing/writing-and-running-benchmarks.md | Updated command path for running benchmarks. |
| benchmark/source_map/source-map.js | Added new benchmarks for various source map operations. |
| benchmark/source_map/source-map-cache.js | Added benchmarks for caching source maps. |
| benchmark/source_map/prepare-stack-trace.js | Introduced benchmarks for preparing stack traces with source maps. |
| benchmark/es/error-stack.js | Updated benchmark operation name for consistency. |
Comments suppressed due to low confidence (1)
benchmark/es/error-stack.js:13
- [nitpick] The operation name was changed from 'node-module-sourcemap' to 'node-modules-sourcemap'. Please confirm that this updated naming is intentional and consistent with other benchmark operation names.
'node-modules-sourcemap']
0b6d29b to
5e438af
Compare
miguelmarcondesf
force-pushed
the
performance-improvements-sourcemap
branch
2 times, most recently
from
5749fce to
bc9fbe9
Compare
…sectioned, and large source maps
…ons on other source map types
…n for prepare stack trace
…n for source map cache
miguelmarcondesf
force-pushed
the
performance-improvements-sourcemap
branch
from
bc9fbe9 to
dc060c0
Compare
miguelmarcondesf
force-pushed
the
performance-improvements-sourcemap
branch
from
f1040cd to
421ae12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.