-
-
Notifications
You must be signed in to change notification settings - Fork 27
Added support for On-Demand Capacity, local DynamoDB instance and rewriting the tables when importing the schema #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…e script together with the read and write capacity parameters.
Hi! thanks for the PR
Here's what i'm thinking:
Maybe you can make a separate PRs for the different features? |
Yep, these are exactly the 4 changes I'd like to implement. The use case: a local (dev env) import of an existing DynamoDB table with on-demand capacity that doesn't exist locally. Deleting the table as a separate command may also be useful, I agree. However, what I wanted to implement was deleting the table if needed in the import command (so that we don't care if the table exists while importing and don't even need to check). So I'd say that it would be another, the 5th feature :) I think separating the features into different PRs could make sense but it would take more time. I'm good with waiting for more feedback from others (maybe we could tag them here to get it earlier), but see more sense in shipping these small features as a bundle, since the bundle is not so big. Which parts of the logic would you like me to explain more? Would code comments do or the README file modifications are needed in your opinioin? |
This would be great, I need to import to a local database using the docker image, but there is no way to set the endpoint url |
Hi again. I just did a rewrite to ESM. If someone wants to address my concerns above and create separate PR's I'm happy to merge |
I must also mention @jilykate here, as she contributed at the beginning of this change.