Improved manifest validations for MSI and Windows Feature names#6169
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
@JohnMcPMS - I thought most of that spelling was already fixed; is your branch behind master? |
florelis
approved these changes
Apr 22, 2026
JohnMcPMS
added a commit
that referenced
this pull request
Apr 23, 2026
CP of #6169 onto main branch. ## Change Adds some additional validation for MSI switches and Windows Feature names: 1. MSI switches are checked during full manifest validation in the same way that they are checked when we attempt to use the MSI APIs rather than msiexec. The API is used for fully all silent installs of MSIs, so we now ensure that those will work (6 total manifests in winget-pkgs were found that needed fixes). 2. Windows Feature names in dependencies are validated to be { alphanumeric, `-`, `_` }. This is done both during full manifest validation and at runtime. A PowerShell script (tools/ManifestValidation/Invoke-ManifestValidation.ps1) is added that will run `wingetdev validate` against a directory recursively and generate a report. There is support for resuming in the middle of the run. This would probably perform much better if it were updated to use the WinGetUtil API, but that can be a future project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Adds some additional validation for MSI switches and Windows Feature names:
-,_}. This is done both during full manifest validation and at runtime.Validation
A PowerShell script (tools/ManifestValidation/Invoke-ManifestValidation.ps1) is added that will run
wingetdev validateagainst a directory recursively and generate a report. There is support for resuming in the middle of the run. This would probably perform much better if it were updated to use the WinGetUtil API, but that can be a future project.The script was run against the entire winget-pkgs repository to ensure no significant impact, and the few manifests that were found will be fixed.
Unit tests are added.
Microsoft Reviewers: Open in CodeFlow