Conversation
nohwnd
approved these changes
Jan 13, 2026
This was referenced Jan 27, 2026
nohwnd
added a commit
to nohwnd/vstest
that referenced
this pull request
Mar 25, 2026
Add 32 new test files covering 30 areas of bug fixes that were merged without corresponding tests. Each test documents which PR/issue it prevents from regressing. Areas covered: - TestProperty.Equals ID-based equality (microsoft#15370) - TraitCollection.GetTraits with EqualityComparer (microsoft#15370, microsoft#15249) - CommandLineUtilities backslash-quote parsing (microsoft#15304) - ManagedNameParser F# method name unescaping (microsoft#4972) - ManagedNameParser edge cases (microsoft#15259, microsoft#15255) - Condition evaluation operations refactor (microsoft#15357) - Condition parsing and tokenization (microsoft#15357) - TrackableEvent subscribe/notify/wait (microsoft#4553) - PathConverter path replacement for UWP (microsoft#3367) - NullPathConverter singleton pattern (microsoft#3367) - PathConverter attachment handling (microsoft#3367) - PathConverter DiscoveryCriteria/TestRunCriteria (microsoft#3367) - DiscoveryDataAggregator source status tracking (microsoft#3381) - DiscoveryCompleteEventArgs status properties (microsoft#3381) - DiscoveryCriteria constructor behavior (microsoft#3381) - JsonDataSerializer discovery status (microsoft#3381) - JsonDataSerializer payload serialization (microsoft#3381) - LengthPrefixCommunicationChannel TrackableEvent (microsoft#4553) - TrxLogger WarnOnFileOverwrite parameter (microsoft#5141) - VSTestTask2 message parsing and error codes (microsoft#5115, microsoft#5113) - VSTestTask2 ANSI escape handling (microsoft#5084) - VSTestTask2 duration formatting (microsoft#4894) - TestHostManagerCallbacks error as informational (microsoft#5192) - ConsoleLogger MinimalTestResult timing fix (microsoft#5143) - TestResult timing properties (microsoft#5143, microsoft#4894) - TestCase serialization with traits (microsoft#15370) - TestObject property storage (microsoft#15370, microsoft#15249) - Condition ValidForProperties (microsoft#15357) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nohwnd
added a commit
that referenced
this pull request
Mar 30, 2026
* Deprecate EnableShutdownAfterTestRun which is no-op * Add regression tests for untested bug fixes Add 32 new test files covering 30 areas of bug fixes that were merged without corresponding tests. Each test documents which PR/issue it prevents from regressing. Areas covered: - TestProperty.Equals ID-based equality (#15370) - TraitCollection.GetTraits with EqualityComparer (#15370, #15249) - CommandLineUtilities backslash-quote parsing (#15304) - ManagedNameParser F# method name unescaping (#4972) - ManagedNameParser edge cases (#15259, #15255) - Condition evaluation operations refactor (#15357) - Condition parsing and tokenization (#15357) - TrackableEvent subscribe/notify/wait (#4553) - PathConverter path replacement for UWP (#3367) - NullPathConverter singleton pattern (#3367) - PathConverter attachment handling (#3367) - PathConverter DiscoveryCriteria/TestRunCriteria (#3367) - DiscoveryDataAggregator source status tracking (#3381) - DiscoveryCompleteEventArgs status properties (#3381) - DiscoveryCriteria constructor behavior (#3381) - JsonDataSerializer discovery status (#3381) - JsonDataSerializer payload serialization (#3381) - LengthPrefixCommunicationChannel TrackableEvent (#4553) - TrxLogger WarnOnFileOverwrite parameter (#5141) - VSTestTask2 message parsing and error codes (#5115, #5113) - VSTestTask2 ANSI escape handling (#5084) - VSTestTask2 duration formatting (#4894) - TestHostManagerCallbacks error as informational (#5192) - ConsoleLogger MinimalTestResult timing fix (#5143) - TestResult timing properties (#5143, #4894) - TestCase serialization with traits (#15370) - TestObject property storage (#15370, #15249) - Condition ValidForProperties (#15357) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Youssef1313 <youssefvictor00@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 7, 2026
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is refactoring-only change. Previously, Equals/NotEquals (and Contains/DoesNotContain) logic was duplicated, but just negated. Now the logic is implemented once, and when the negated operator is needed, we call the positive implementation and negate the result.