Do not auto-trigger suggest when typing exactly the inline suggestion #126413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Henning Dieterichs <[email protected]>
alexdima
added
the
candidate
jrieken
approved these changes
Jun 16, 2021
| function shouldPreventQuickSuggest(contextKeyService: IContextKeyService, configurationService: IConfigurationService): boolean { | ||
| return ( | ||
| Boolean(contextKeyService.getContextKeyValue<boolean>('inlineSuggestionVisible')) | ||
| && !Boolean(configurationService.getValue<boolean>('editor.inlineSuggest.allowQuickSuggestions')) |
There was a problem hiding this comment.
For a small change you could be reading the config via the context key service, e.g config.editor.inlineSuggest.allowQuickSuggestions
There was a problem hiding this comment.
Oh, each config is exposed as context key? Should we change that?
There was a problem hiding this comment.
I think it's fine, it was more for fyi
hediet
approved these changes
Jun 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only when inline suggestions are visible:
editor.inlineSuggest.allowQuickSuggestionsthat can be set totrueto get the old behavior.editor.inlineSuggest.allowSuggestOnTriggerCharactersthat can be set totrueto get the old behavior.There is no change if inline suggestions are not visible.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/2208
inlineSuggestionVisiblecontext key (not detected in tests - it is only a bug when users want to use that key). This is important if users/copilot want to check if an inline suggestion is visible / use it in keybindings.editor.inlineSuggest.enabledis changed. This is important when copilot sets this setting to true.