Safari not properly rendering Terminal after page reload

[benz0li]

Does this issue occur when all extensions are disabled?: Yes/No
👉 Not relevant.

• VS Code Version: 1.71.0, 784b017, x64
• OS Version: Debian 11 (bullseye)

Steps to Reproduce:

1. Open codespace in browser
2. Open Terminal
   • Safari falls back to the DOM render, as canvas can not be loaded [and WebGL is not supported disabled for Safari by VS Code].
3. Reload page
   👉 An artefact is overlaying the output in the Terminal.
   

Everything works fine with Firefox as it uses the WebGL renderer.

[benz0li]

Workaround for Safari: Disable Gpu Acceleration (= using the DOM renderer)

Settings

Settings (JSON)

"terminal.integrated.gpuAcceleration": "off"

[benz0li]

@meganrogge @Tyriar Has the time come to enable WebGL for Safari?

diff --git a/src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts b/src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
index b27a4b3e847..863892baee8 100644
--- a/src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
+++ b/src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
@@ -282,7 +282,7 @@ export class XtermTerminal extends DisposableStore implements IXtermTerminal, II
        }
 
        private _shouldLoadWebgl(): boolean {
-               return !isSafari && (this._configHelper.config.gpuAcceleration === 'auto' && XtermTerminal._suggestedRendererType === undefined) || this._configHelper.config.gpuAcceleration === 'on';
+               return (this._configHelper.config.gpuAcceleration === 'auto' && XtermTerminal._suggestedRendererType === undefined) || this._configHelper.config.gpuAcceleration === 'on';
        }
 
        private _shouldLoadCanvas(): boolean {

Cross reference: xtermjs/xterm.js#3357 (comment)

[jeanp413]

Created a PR fixing it #160144

[Tyriar]

The webgl renderer would probably have the same problem if it's related to device-pixel-content-box as it also uses it. I believe the addon works in Safari now, but it used to show a completely empty canvas, bricking the terminal so we should probably wait a little longer.