🐛 use 32bit integers for threadid in protocol layer #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archive of 0.7.0
* 'master' of https://github.com/Microsoft/vscode-python: Fixes #56 list all environments (#219) Fixes #57 Disable activation on debugging (#220) Fixes #26 Do not run linters when linters are disabled (#222)
* upstream/master: Fix typo in README.md (#252) Disable linter without workspaces (#241)
* upstream/master: Fix feedback service (#246) Fix django context initializer (#248) disable generation of tags file upon extension load (#264)
* upstream/master: Resolve pythonPath before comparing it to shebang (#273)
* upstream/master:
Fixes #22 to Detect anaconda from known locations (#221)
Use workspaceFolder token instead of workspaceRoot (#267)
Fix registry lookup response (#224)
Fix issues when running without debugging and debugged code terminates (#249)
* upstream/master: Fix debugging tests (#304)
* upstream/master: Remove jupyter functionality in favor of Jupyter extension (#302) Drop Python 2 URLs (#307)
* upstream/master: Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)
* upstream/master: Remove setting linting.lintOnTextChange as it was never implemented (#315)
* upstream/master: Fix travis build error (#326)
* upstream/master: add new npm deps with improved gulp for dev (#328)
* upstream/master: Update version of inversify package (#329)
* upstream/master: Document our dev process (#330)
* upstream/master: Document contribution to the code along with coding standards (#321)
* upstream/master: Add Simplified Chinese translation of commands (#240)
* upstream/master: Fix package.json (#347)
* upstream/master: #34, #110 - suppress Intellisense in strings and comments (#339) Re-factor code python execution framework (#345)
* upstream/master: Fix linters to make use of the new python code execution framework (#360) Update the versioning scheme (#356) Make npm happy in regards to line endings (#357)
* upstream/master: Ensure python path is not set if already set in user settings (#369) Use 'an' rather than 'a' before vowel words (#373)
* upstream/master: Use new environment variable parser (#362)
* upstream/master: Add `pudb` set trace statement to snippets (#370)
* upstream/master: Fix auto-indent regex rules (#562) Fix linter installation (#557) Upload buillds to azure (#534) Delete package-lock.json file (#550) Fix exception reported in #447 (#536)
* upstream/master: Move badges to the official location within package.json (#587) Update contributing guide to mention our monthly release cycle (#567) Move issue template to the .github directory (#566)
* upstream/master: Added unit test attaching a debugger (#597) Add delay for exec in terminal (#592) Update TPN for opn and arch (#600) Clean build output (#595) import specific parts of rxjs to speed up loading (#596)
* upstream/master: update reflect metadata dependency (#604)
* upstream/master: WIP - Activate environment in terminal (#614) Add telemetry for debugger (#546)
* upstream/master: Implements linting configuration (#599)
* upstream/master: Add command to create a python terminal (#625) Always display interpreter status bar (#623) Do not clear interpreter cache (#621)
* upstream/master: Create a release candidate (#663) Activation of terminal using conda activate and fixes to powershell script execution (#665)
* upstream/master: Validate file execution handler (#698) Update contributing guide (#687) Formatting on Enter (#649) Start the 2018.2.0 alpha (#685) Prep for 2018.1 final (#683) Speed up interpreter locators (#676)
* upstream/master: Debug specific unittest test ends up running all failed tests (#671) Fix unhandled promise rejections (#702) 🐛 Fixes #700 replace back slashes in fie paths with forward slashes (#707) Validate file execution handler (#698) Update contributing guide (#687) Formatting on Enter (#649) Start the 2018.2.0 alpha (#685) Prep for 2018.1 final (#683) Speed up interpreter locators (#676) Create a release candidate (#663) Activation of terminal using conda activate and fixes to powershell script execution (#665) Register linter commands (#653) Preserve focus when sending text to a terminal (#651) Work around VSC issue with formatting on save #624 (#635) Korean translation (#540) Improving getting started instructions in README and minor updates to contributors guide (#605) Bump to a beta version for some testing (#630) Activate extension when command 'Create Terminal' is invoked (#632)
* upstream/master: Debugger unit tests (#724)
* upstream/master: Renamed default configuration name (#712) Improve tooltip display (#725)
* upstream/master: Renamed default configuration name (#712) Improve tooltip display (#725) Debugger unit tests (#724)
* upstream/master: Limit Jedi RAM consumption (#744) Fix debug test failure (#739) Ensure paths are always using forward slashes in terminal commands and args (#732)
* upstream/master: Add support for latest version of PTVSD as an experimental debugger (#745)
| response.body = { | ||
| stackFrames: [] | ||
| }; | ||
| return this.sendResponse(response); | ||
| } | ||
|
|
||
| const pyThread = this.pythonProcess!.Threads.get(args.threadId)!; | ||
| const pyThread = Array.from(this.pythonProcess!.Threads.values()).find(t => t.Int32Id === args.threadId)!; |
There was a problem hiding this comment.
Might be worth encapsulating search into IPythonProcess.threadFromIn32Id()
| @@ -38,13 +38,14 @@ export function validatePathSync(filePath: string): boolean { | |||
| return exists; | |||
| } | |||
|
|
|||
| export function CreatePythonThread(id: number, isWorker: boolean, process: IPythonProcess, name: string = ''): IPythonThread { | |||
| export function CreatePythonThread(id: number, isWorker: boolean, process: IPythonProcess, name: string = '', int32Id: number = 0): IPythonThread { | |||
There was a problem hiding this comment.
in HandleThreadCreate we are passing process to utils.CreatePythonThread. It might be better to make CreatePythonThread private within PythonProcess since all we really do in HandleThreadCreate is creating thread and then adding it to the process thread list. The PythonProcess could just do it internally. You probably wouldn't need _createdFirstThread either then.
There was a problem hiding this comment.
On a related note, things like
if (this.process.Threads.has(threadId)) {
pyThread = this.process.Threads.get(threadId)!;
}
could be encapsulated inside PythonProcess method since sequence appears to be repeated quite a bit. Moveover
let threadId = this.stream.ReadInt64();
if (this.stream.HasInsufficientDataForReading) {
return;
}
let pyThread: IPythonThread | undefined;
if (this.process.Threads.has(threadId)) {
pyThread = this.process.Threads.get(threadId)!;
}
appears to be used a lot too. Maybe make getThreadFromStream
There was a problem hiding this comment.
Reluctant to make any changes, as all of the work would be obsolete with the new debugger work.
MikhailArkhipov
approved these changes
Feb 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
- Coverage 62.15% 62.15% -0.01%
==========================================
Files 251 251
Lines 11588 11589 +1
Branches 2074 2074
==========================================
Hits 7203 7203
- Misses 4377 4378 +1
Partials 8 8
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #760