Skip to content

Correctly display native REPL execution status #23797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 18, 2024
Merged

Correctly display native REPL execution status #23797

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
357f9d5
correctly display execution status
anthonykim1 Jul 11, 2024
ce622bc
send execution status from python_server
anthonykim1 Jul 12, 2024
12d3ebb
clean up
anthonykim1 Jul 12, 2024
5f228e2
pass in object instead of string
anthonykim1 Jul 12, 2024
7eb33bd
cleanup
anthonykim1 Jul 12, 2024
e86cdd3
lint
anthonykim1 Jul 15, 2024
0e1ecae
remove dup executionStatus, remove comment
anthonykim1 Jul 15, 2024
3127da0
add interface, remove !== from result.output
anthonykim1 Jul 15, 2024
28d182c
remove result conditional
anthonykim1 Jul 15, 2024
fcb994b
add undefined as return type, try catch
anthonykim1 Jul 15, 2024
05eb6e4
remove unncessary try catch
anthonykim1 Jul 15, 2024
a6d044b
refactor send_message, still need to leverage ErrorResponse
anthonykim1 Jul 15, 2024
ff239cf
remove all related NotebookCellOutputItem.error component for now
anthonykim1 Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/repl/replController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function createReplController(
new vscode.NotebookCellOutput([vscode.NotebookCellOutputItem.text(result, 'text/plain')]),
]);
}
exec.end(true);
exec.end(!result.startsWith('Traceback (most recent call last):'));
} catch (err) {
const error = err as Error;
exec.replaceOutput([
Expand Down