Skip to content

backwards compatible hookwrapper for pytest_xdist_auto_num_workers doesn't work #23816

@DetachHead

Description

@DetachHead

Type: Bug

Behaviour

the change in #23781 now causes the pytest plugin to crash

2024-07-16 09:27:28.042 [error]   File "c:\Users\user\.vscode\extensions\ms-python.python-2024.11.2024071501-win32-x64\python_files\vscode_pytest\__init__.py", line 894, in pytest_xdist_auto_num_workers

2024-07-16 09:27:28.042 [error]     return min((yield), len(config.option.file_or_dir))

2024-07-16 09:27:28.042 [error]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError
2024-07-16 09:27:28.042 [error] : '<' not supported between instances of 'int' and 'Result'

the fix i suggested here will fix the crash, but for some reason using hookwrapper instead of wrapper causes the hook to not work at all, and i can't figure out why. i will do some more investigating and see i can figure it out

Steps to reproduce:

  1. run pytest collection by clicking the refresh button in the test explorer
  2. click "Show output" on the error message

environment information

pytest version: 8.2.2
pluggy version: 1.5.0

Extension version: 2024.11.2024071501 (i manually updated the pytest plugin with the change from #23781)
VS Code version: Code 1.91.0 (ea1445cc7016315d0f5728f8e8b12a45dc0a7286, 2024-07-01T18:52:22.949Z)
OS version: Windows_NT x64 10.0.22621
Modes:

Metadata

Metadata

Assignees

Labels

area-testingbugIssue identified by VS Code Team member as probable bugneeds PRReady to be worked onverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions