Skip to content

Consider removing extensions to prototypes of base types in favor of custom functions #18871

@karrtikr

Description

@karrtikr

We're editing the String interface itself by extending String.prototype, the issue with that is that other extensions which might share the same typing names might override our prototypes, for eg. fileToCommandArgument() also exists in Jupyter extension.

Convert all these to functions similar to like we have done with asyncFilter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-internalLabel for non-user facing issuesdebtCovers everything internal: CI, testing, refactoring of the codebase, etc.needs PRReady to be worked on

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions