Show PR review status #4187
Merged
Show PR review status #4187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #681
joaomoreno
previously approved these changes
Nov 17, 2022
sandy081
approved these changes
Nov 21, 2022
eslamashour1
pushed a commit
to eslamashour1/vscode-pull-request-github
that referenced
this pull request
Dec 31, 2022
* Show PR review status Fixes microsoft#681 * Always get review required check and add unknown * Fix tests * Also add decoration for changes requested * Use codicons * Udpate decoration API * Try to address some feedback
dippi
reviewed
Jan 16, 2023
| const labelPrefix = currentBranchIsForThisPR ? '✓ ' : ''; | ||
| const tooltipPrefix = currentBranchIsForThisPR ? 'Current Branch * ' : ''; | ||
| const formattedPRNumber = number.toString(); | ||
| const label = `${labelPrefix}#${formattedPRNumber}: ${isDraft ? '[DRAFT] ' : ''}${title}`; |
There was a problem hiding this comment.
Hi @alexr00,
I noticed that the PR numbers are no longer displayed in the tree view.
I skimmed the discussion in #681 and I didn't find the change addressed explicitly.
So I was wondering if they were removed for a reason or it's just something that slipped through among the other experiments and changes.
Best!
Member
Author
There was a problem hiding this comment.
@dippi I removed them because they added a lot of visual noise to the PRs tree view and I didn't think they were very useful. They also took space away from the title of the PR, which is more important than the number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #681