Delay importing the util package to fix browser compatibility#103
Open
johnsoncodehk wants to merge 1 commit into
Open
Delay importing the util package to fix browser compatibility#103johnsoncodehk wants to merge 1 commit into
johnsoncodehk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes vuejs/repl#258
vscode-emmet-helper/src/emmetHelper.ts
Line 1038 in a04604f
This line uses the TextDecoder imported from the util package as a fallback for the Node.js environment. However, since the util package is imported globally, it always breaks browser execution.
The fix is to lazily import the util package only within the fallback branch for the Node.js environment.
Related to browserify/node-util#77.