Background - agent session changes caching #3337
Merged
+108
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the chat session worktree changes caching mechanism by moving from a separate in-memory Map (_sessionWorktreeChanges) to storing the changes as part of the persisted ChatSessionWorktreeProperties. This consolidates state management and ensures changes are persisted alongside other worktree metadata.
Changes:
- Introduced
ChatSessionWorktreeFileinterface to represent file changes with a simpler, serializable structure - Modified
ChatSessionWorktreePropertiesto include an optionalchangesfield for caching worktree file changes - Refactored
getWorktreeChangesto store/retrieve cached changes from worktree properties instead of a separate Map - Updated conversion logic in
copilotCLIChatSessionsContribution.tsto transformChatSessionWorktreeFiletovscode.ChatSessionChangedFile2with proper Git URIs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/extension/chatSessions/common/chatSessionWorktreeService.ts | Added ChatSessionWorktreeFile interface and changes field to ChatSessionWorktreeProperties |
| src/extension/chatSessions/vscode-node/chatSessionWorktreeServiceImpl.ts | Removed _sessionWorktreeChanges Map, refactored caching to use worktree properties, updated cache invalidation logic |
| src/extension/chatSessions/vscode-node/copilotCLIChatSessionsContribution.ts | Added conversion from ChatSessionWorktreeFile to vscode.ChatSessionChangedFile2 with Git URI mapping |
src/extension/chatSessions/vscode-node/chatSessionWorktreeServiceImpl.ts
Outdated
Show resolved
Hide resolved
DonJayamanne
approved these changes
Feb 2, 2026
lszomoru
added a commit
that referenced
this pull request
Feb 2, 2026
* Initial implementation * Second iteration * Pull request feedback * Fix opening the changes from the session * Disable the Apply action in the empty window * Hide Apply action in empty window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.