Preserve copilotTracking ID (tid) in telemetry when token is reset #3308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijayupadya
added
the
bug
justschen
approved these changes
Jan 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes missing copilotTracking ID (tid) values in error telemetry events by preserving the last known tid when the Copilot token is reset to undefined.
Changes:
- Modified
processTokento preserve the tid value when a token becomes undefined, rather than clearing it immediately - Added conditional logic to only update tid when a new valid value is available
Comment on lines
+117
to
+121
| // Only update tid if we have a new valid value - preserve last known tid for error telemetry where token may be undefined | ||
| const newTid = token?.getTokenValue('tid'); | ||
| if (newTid) { | ||
| this._tid = newTid; | ||
| } |
There was a problem hiding this comment.
The preservation of tid creates an asymmetry with how username and sku are handled when the token becomes undefined. Consider documenting why tid requires different treatment compared to other token-derived fields. This will help future maintainers understand that tid serves as a session correlation identifier that should persist across temporary token unavailability, while username and sku represent current state that can be cleared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/6678
Fixes missing copilotTracking ID (tid) values in error telemetry events (e.g., [response.error] for quotaExceeded, badRequest).
When the Copilot token is reset due to HTTP 401/402/403 responses, the telemetry sender was clearing the tid value immediately. Since error telemetry is sent after the token reset, these events were missing the tracking ID.
The fix preserves the last known tid value instead of clearing it when the token becomes undefined, ensuring error events can still be correlated with the user session that made the request.