Remove alternate Zai prompt configuration experiment #3284
Merged
+2
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the experimental “alternate Zai prompt” configuration/experiment and makes the Zai-specific agent prompt the default whenever the Zai model matcher applies.
Changes:
- Deleted the
EnableAlternateZaiPromptexperiment-backed config key and its contributed setting/description. - Removed experimentation/configuration dependency from the Zai prompt resolver and always resolve to
DefaultZaiAgentPrompt. - Cleaned up package localization and settings schema entries associated with the removed config.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/platform/configuration/common/configurationService.ts | Removes the experiment-based config key for the alternate Zai prompt. |
| src/extension/prompts/node/agent/zaiPrompts.tsx | Removes experiment gating/DI dependencies; always uses the Zai prompt for matching models. |
| package.nls.json | Removes the localized description string for the removed setting. |
| package.json | Removes the contributed configuration entry for github.copilot.chat.alternateZaiPrompt.enabled. |
kionas-dev
approved these changes
Jan 29, 2026
pwang347
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.