Skip to content

Conversation

@chrmarti
Copy link
Collaborator

Copilot AI review requested due to automatic review settings January 29, 2026 17:50
@chrmarti chrmarti enabled auto-merge January 29, 2026 17:51
@chrmarti chrmarti self-assigned this Jan 29, 2026
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 29, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves Copilot Chat authentication error handling and related UX, including a dedicated state for GitHub login failures.

Changes:

  • Add a debug configuration switch to simulate specific GitHub auth/token failure reasons.
  • Introduce a distinct GitHubLoginFailed error type and surface it via a new welcome message/context key.
  • Add additional logging around activation/deactivation and context key updates.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/platform/configuration/common/configurationService.ts Adds a new debug setting for simulating GitHub auth failures.
src/platform/authentication/vscode-node/copilotTokenManager.ts Adds GitHubLoginFailedError and supports debug-simulated auth failure reasons.
src/extension/conversation/vscode-node/conversationFeature.ts Adds log statements when activating/deactivating contributions.
src/extension/contextKeys/vscode-node/contextKeys.contribution.ts Adds a new context key/state for GitHub login failure and updates error→context mapping.
package.nls.json Updates the invalid-token welcome message action and adds a new GitHub-login-failed welcome message.
package.json Registers the new welcome card and updates walkthrough gating conditions to include the new state.

Tyriar
Tyriar previously approved these changes Jan 29, 2026
@Tyriar
Copy link
Member

Tyriar commented Jan 29, 2026

@chrmarti consider the comments above ☝️

@chrmarti chrmarti force-pushed the chrmarti/zonal-chicken branch from f5c7178 to dcd38b6 Compare January 29, 2026 19:42
@chrmarti chrmarti added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit 3edc370 Jan 29, 2026
19 checks passed
@chrmarti chrmarti deleted the chrmarti/zonal-chicken branch January 29, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants