-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Improve error handling #3278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve error handling #3278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Improves Copilot Chat authentication error handling and related UX, including a dedicated state for GitHub login failures.
Changes:
- Add a debug configuration switch to simulate specific GitHub auth/token failure reasons.
- Introduce a distinct
GitHubLoginFailederror type and surface it via a new welcome message/context key. - Add additional logging around activation/deactivation and context key updates.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/platform/configuration/common/configurationService.ts | Adds a new debug setting for simulating GitHub auth failures. |
| src/platform/authentication/vscode-node/copilotTokenManager.ts | Adds GitHubLoginFailedError and supports debug-simulated auth failure reasons. |
| src/extension/conversation/vscode-node/conversationFeature.ts | Adds log statements when activating/deactivating contributions. |
| src/extension/contextKeys/vscode-node/contextKeys.contribution.ts | Adds a new context key/state for GitHub login failure and updates error→context mapping. |
| package.nls.json | Updates the invalid-token welcome message action and adds a new GitHub-login-failed welcome message. |
| package.json | Registers the new welcome card and updates walkthrough gating conditions to include the new state. |
src/extension/contextKeys/vscode-node/contextKeys.contribution.ts
Outdated
Show resolved
Hide resolved
Tyriar
previously approved these changes
Jan 29, 2026
Member
|
@chrmarti consider the comments above ☝️ |
ac6ff93 to
f5c7178
Compare
f5c7178 to
dcd38b6
Compare
bpasero
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/vscode#290234