Avoid checking if copilot cli version cannot not be parsed in powershell script #3254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame as ts script) for Copilot CLI in terminal
DonJayamanne
changed the title
pwang347
approved these changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Copilot CLI PowerShell shim so that a successful --version invocation is treated as success even if the version string cannot be parsed, avoiding unnecessary reinstall prompts and failures. It still performs version compatibility checks when a valid semantic version is detected.
Changes:
- Removed the branch that treated an unparsable
--versionoutput as an error requiring a reinstall prompt. - Added comments clarifying that a successful
--versioncall implies a valid installation even without a parseable version. - Updated the version compatibility check to run only when a version value was successfully extracted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#291461