Skip to content

Conversation

@ulugbekna
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 28, 2026 22:45
@ulugbekna ulugbekna enabled auto-merge January 28, 2026 22:45
@ulugbekna ulugbekna self-assigned this Jan 28, 2026
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 28, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR threads Next Edit telemetry through the Ghost Text (inline completion) pipeline to support recording whether a suggestion was shown (isShown) and whether it was served from cache (isFromCache).

Changes:

  • Pass an LlmNESTelemetryBuilder through GhostText.getInlineCompletions(...)getGhostText(...)GhostTextComputer so the ghost-text pipeline can annotate NES telemetry.
  • Mark completions as shown by calling setAsShown() when an inline completion item is displayed.
  • Update internal callers and unit tests to provide the new telemetry builder parameter.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/lib/node/chatLibMain.ts Creates and passes an LlmNESTelemetryBuilder into ghost text inline completion requests.
src/extension/completions-core/vscode-node/lib/src/test/inlineCompletion.test.ts Updates tests to pass the new telemetry builder parameter.
src/extension/completions-core/vscode-node/lib/src/prompt/test/prompt.ts Updates prompt test helper to pass the new telemetry builder parameter.
src/extension/completions-core/vscode-node/lib/src/inlineCompletion.ts Adds telemetryBuilder parameter to GhostText.getInlineCompletions(...) and propagates it to ghost text computation (including speculative requests).
src/extension/completions-core/vscode-node/lib/src/ghostText/test/ghostText.test.ts Updates ghost text unit tests to pass the new telemetry builder parameter.
src/extension/completions-core/vscode-node/lib/src/ghostText/ghostText.ts Adds cache detection to set telemetryBuilder.isFromCache when cached results are used.
src/extension/completions-core/vscode-node/extension/src/vscodeInlineCompletionItemProvider.ts Sets isShown on the telemetry builder when VS Code reports an item was shown.
src/extension/completions-core/vscode-node/extension/src/ghostText/ghostTextProvider.ts Passes telemetryBuilder.nesBuilder into GhostText.getInlineCompletions(...).

@ulugbekna ulugbekna added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit a737348 Jan 28, 2026
25 checks passed
@ulugbekna ulugbekna deleted the ulugbekna/ghost-provideInlineEdit-2 branch January 28, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants