add PUT method support to FetchOptions #3234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for PUT requests to the shared FetchOptions type and updates Node-based fetcher implementations to accept and type PUT correctly.
Changes:
- Expanded
FetchOptions.methodto include'PUT'. - Updated
NodeFetcherto allow and type'PUT'for its internal request path. - Updated
BaseFetchFetcher(and thus fetch-based implementations like Undici/Electron) to allow and type'PUT'.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/platform/networking/node/nodeFetcher.ts | Allows PUT in method validation and updates _fetch method type to include PUT. |
| src/platform/networking/node/baseFetchFetcher.ts | Allows PUT in method validation and updates _fetch method type to include PUT for fetch-based implementations. |
| src/platform/networking/common/fetcherService.ts | Extends FetchOptions.method union type to include PUT. |
pwang347
previously approved these changes
Jan 28, 2026
… package-lock.json
joshspicer
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.