Skip to content

Conversation

@jlaanstra
Copy link
Contributor

#40771 added an if block for Windows resulting in stack protector getting disabled. This change re-enables the stack protector for Windows as it was before.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

microsoft#40771 added an if block for Windows resulting in stack protector getting disabled. This change re-enables the stack protector for Windows as it was before.
@dg0yt
Copy link
Contributor

dg0yt commented Oct 15, 2025

I would suggest to place a reasonable default before the if line, and to have extra lines only in the branches which need the other value.

@BillyONeal BillyONeal changed the title Set STACK_PROTECTOR ON for Windows builds [opus] Set STACK_PROTECTOR ON for Windows builds Oct 16, 2025
@BillyONeal BillyONeal added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 16, 2025
@BillyONeal BillyONeal enabled auto-merge (squash) October 16, 2025 00:38
@BillyONeal BillyONeal disabled auto-merge October 16, 2025 17:31
@BillyONeal BillyONeal merged commit 98ef4fc into microsoft:master Oct 16, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants