-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[reaction] Add new port #47511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reaction] Add new port #47511
Conversation
c3d6457 to
1064283
Compare
|
@microsoft-github-policy-service agree |
ports/reaction/portfile.cmake
Outdated
|
|
||
| vcpkg_cmake_install() | ||
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/reaction) | ||
| file(INSTALL "${SOURCE_PATH}/include/reaction.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done by the CMake project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, removed
ports/reaction/portfile.cmake
Outdated
| file(REMOVE_RECURSE | ||
| "${CURRENT_PACKAGES_DIR}/debug" | ||
| "${CURRENT_PACKAGES_DIR}/lib" | ||
| "${CURRENT_PACKAGES_DIR}/bin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the bin directory even exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
ports/reaction/usage
Outdated
|
|
||
| Example usage: | ||
|
|
||
| #include <reaction.h> | ||
|
|
||
| // Create reactive variables | ||
| auto a = reaction::var(1); | ||
| auto b = reaction::var(2); | ||
|
|
||
| // Create computed values | ||
| auto sum = reaction::calc([]() { return a() + b(); }); | ||
|
|
||
| // Values automatically update when dependencies change | ||
| a.value(10); // sum will automatically update to 12 | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Example usage: | |
| #include <reaction.h> | |
| // Create reactive variables | |
| auto a = reaction::var(1); | |
| auto b = reaction::var(2); | |
| // Create computed values | |
| auto sum = reaction::calc([]() { return a() + b(); }); | |
| // Values automatically update when dependencies change | |
| a.value(10); // sum will automatically update to 12 |
You can add a documentation link to the manifest instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
ports/reaction/vcpkg.json
Outdated
| "features": { | ||
| "cxx20": { | ||
| "description": "Enable C++20 features", | ||
| "supports": "native" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are C++20 features restricted to native? My android toolchain may be much newer than my host toolchain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
20a394a to
303a26c
Compare
|
All done, but CI in x86_windows failed: |
|
It looks like this PR was edited after adding the version database entry. You will have to update the git tree object by running the |
|
@JavierMatosD Thank you, Success. |
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.