Skip to content

Conversation

@lumia431
Copy link
Contributor

@lumia431 lumia431 commented Sep 26, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@lumia431 lumia431 force-pushed the reaction branch 5 times, most recently from c3d6457 to 1064283 Compare September 26, 2025 03:24
@lumia431
Copy link
Contributor Author

@microsoft-github-policy-service agree


vcpkg_cmake_install()
vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/reaction)
file(INSTALL "${SOURCE_PATH}/include/reaction.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done by the CMake project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed

file(REMOVE_RECURSE
"${CURRENT_PACKAGES_DIR}/debug"
"${CURRENT_PACKAGES_DIR}/lib"
"${CURRENT_PACKAGES_DIR}/bin"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the bin directory even exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Comment on lines 5 to 20

Example usage:

#include <reaction.h>

// Create reactive variables
auto a = reaction::var(1);
auto b = reaction::var(2);

// Create computed values
auto sum = reaction::calc([]() { return a() + b(); });

// Values automatically update when dependencies change
a.value(10); // sum will automatically update to 12


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Example usage:
#include <reaction.h>
// Create reactive variables
auto a = reaction::var(1);
auto b = reaction::var(2);
// Create computed values
auto sum = reaction::calc([]() { return a() + b(); });
// Values automatically update when dependencies change
a.value(10); // sum will automatically update to 12

You can add a documentation link to the manifest instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

"features": {
"cxx20": {
"description": "Enable C++20 features",
"supports": "native"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are C++20 features restricted to native? My android toolchain may be much newer than my host toolchain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@lumia431 lumia431 force-pushed the reaction branch 2 times, most recently from 20a394a to 303a26c Compare September 26, 2025 07:49
@lumia431
Copy link
Contributor Author

All done, but CI in x86_windows failed:
PowerShell exited with code '1'.

@JavierMatosD
Copy link
Contributor

It looks like this PR was edited after adding the version database entry. You will have to update the git tree object by running the vcpkg x-add-version reaction --overwrite command. See -> https://learn.microsoft.com/vcpkg/commands/add-version?WT.mc_id=vcpkg_inproduct_cli#--overwrite-version

@JavierMatosD JavierMatosD marked this pull request as draft September 26, 2025 20:18
@lumia431 lumia431 requested a review from dg0yt September 29, 2025 03:19
@lumia431
Copy link
Contributor Author

@JavierMatosD Thank you, Success.

@JavierMatosD JavierMatosD marked this pull request as ready for review September 29, 2025 16:22
@JavierMatosD JavierMatosD merged commit c8680a2 into microsoft:master Sep 29, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants