Port IsSourceFileFromExternalLibrary so that we can implement more paths in sourceFileMayBeEmitted
#1234
+84
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschwenk
commented
Jun 18, 2025
| @@ -970,6 +970,7 @@ func (p *Project) GetFileNames(excludeFilesFromExternalLibraries bool, excludeCo | |||
| result := []string{} | |||
| sourceFiles := p.program.GetSourceFiles() | |||
| for _, sourceFile := range sourceFiles { | |||
| // !! This is probably ready to be implemented now? | |||
There was a problem hiding this comment.
Because we have IsSourceFileFromExternalLibrary
jakebailey
reviewed
Jun 18, 2025
Comment on lines
+834
to
+835
| // IsSourceFileFromExternalLibrary returns true if the source file is from an external library. | ||
| // This mirrors the TypeScript implementation which tracks files found while searching node_modules. |
There was a problem hiding this comment.
I assume some LLM added the comments; I would just remove all of these as they just describe exactly what the code says.
| fileName: resolvedFileName, | ||
| increaseDepth: resolvedModule.IsExternalLibraryImport, | ||
| elideOnDepth: isJsFileFromNodeModules, | ||
| isFromExternalLibrary: isFromNodeModulesSearch, |
There was a problem hiding this comment.
Not just resolvedModule.IsExternalLibraryImport?
Comment on lines
+317
to
+319
| increaseDepth: false, | ||
| elideOnDepth: false, | ||
| isFromExternalLibrary: false, // Triple-slash references are always local files |
There was a problem hiding this comment.
These are all defaulted to false if not present.
Comment on lines
+840
to
+841
| isExternal, exists := p.sourceFilesFoundSearchingNodeModules.Load(file.Path()) | ||
| return exists && isExternal |
There was a problem hiding this comment.
I don't think this should have Load. It's just a map.
| @@ -50,6 +50,9 @@ type processedFiles struct { | |||
| importHelpersImportSpecifiers map[tspath.Path]*ast.Node | |||
| // List of present unsupported extensions | |||
| unsupportedExtensions []string | |||
| // Track which source files were found while searching node_modules | |||
| // Similar to TypeScript's sourceFilesFoundSearchingNodeModules map | |||
| sourceFilesFoundSearchingNodeModules map[tspath.Path]bool | |||
There was a problem hiding this comment.
Use collections.Set[tspath.Path] here.
jakebailey
reviewed
Jun 18, 2025
Comment on lines
+210
to
+214
| if p.processedFiles.sourceFilesFoundSearchingNodeModules != nil { | ||
| for path, isExternal := range p.processedFiles.sourceFilesFoundSearchingNodeModules { | ||
| p.sourceFilesFoundSearchingNodeModules.Store(path, isExternal) | ||
| } | ||
| } |
There was a problem hiding this comment.
This should not be required, the info should already be on processedFiles and therefore be accessible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and close
.tsalongside.jsof the same name, builds are nested #1215