Set maxNodeModuleJsDepth in JS-containing projects #1213
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for setting a maximum depth for Node.js modules in projects that contain JavaScript files. Key changes include:
- Introducing a new field (rootJSFileCount) to track the count of JS files.
- Updating project configuration in updateProgram() to set a default MaxNodeModuleJsDepth when JS files are present.
- Refactoring root file management by replacing direct map access with helper methods that update the JS file count.
| @@ -561,6 +562,12 @@ func (p *Project) updateProgram() bool { | |||
| } else { | |||
| rootFileNames := p.GetRootFileNames() | |||
| compilerOptions := p.compilerOptions | |||
|
|
|||
| if compilerOptions.MaxNodeModuleJsDepth == nil && p.rootJSFileCount > 0 { | |||
| compilerOptions = compilerOptions.Clone() | |||
There was a problem hiding this comment.
There is method GetCompilerOptions - do you need to modify that instead and scan through other usage of p.compilerOptions ?
There was a problem hiding this comment.
That method is actually unused except for the API package, so I opted to not modify that. I could theoretically do that, though, yes.
There was a problem hiding this comment.
Tried, but the concurrency story on this is pretty weird. I'd rather just leave this here for now and fix it if we need this option set for something else eventually. It'll probably get easier with the snapshot refactor.
Could use a test, but this looks correct to me in theory.
Fixes #1209