Skip to content

Add handling for 2-3 invalid overload candidates #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

muglug
Copy link
Contributor

@muglug muglug commented Jun 7, 2025

Fixes #1088 by filling in missing logic for handling 2-3 overload errors.

@muglug
Copy link
Contributor Author

muglug commented Jun 7, 2025

Actually it doesn't fix it, yet. Boo.

@muglug muglug closed this Jun 7, 2025
@jakebailey
Copy link
Member

jakebailey commented Jun 7, 2025

I'm pretty sure that this difference is intentional, specifically the "not showing a billion messages anymore" in favor of "just report the last one". Though, obviously this does appear to improve the diffs.

@jakebailey
Copy link
Member

I don't quite see how this is related to #1088?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behavior between tsc and tsgo for @ts-expect-error directive placement
2 participants