Perf: Reduce allocations from ManagedNameHelper #6367
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Aug 13, 2025
Comment on lines
-157
to
-165
|
|
||
| // VSTest managed feature is not working properly and ends up providing names that are not fully | ||
| // unescaped causing reflection to fail loading. For the cases we know this is happening, we will | ||
| // try to manually unescape the type name and load the type again. | ||
| if (type == null | ||
| && TryGetUnescapedManagedTypeName(testMethod, out string? unescapedTypeName)) | ||
| { | ||
| type = LoadType(unescapedTypeName, testMethod.AssemblyName); | ||
| } |
There was a problem hiding this comment.
I need to validate if there are any F# issues here with types containing spaces or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario: 10k tests in a test class
Memory allocations before: ~227MB
Memory allocations after: ~208MB