Mark TestHostControllersTestHost constructor as Unsupported browser #6047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can remove the repetitive `pragma warning disable CA1416`
Youssef1313
reviewed
Jul 16, 2025
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostControllersTestHost.cs
Outdated
Show resolved
Hide resolved
Youssef1313
requested changes
Jul 16, 2025
There was a problem hiding this comment.
A better option here is to mark the constructor itself as unsupported, instead of InternalRunAsync. That way we can get the warning to propagate up correctly. Then, in TestHostBuilder when we are about to create TestHostControllersTestHost, we will do a check for browser and throw an exception.
…llersTestHost.InternalRunAsync-as-Unsupported-browser
SimonCropp
changed the title
|
@Youssef1313 done |
microsoft-github-policy-service
bot
added
Needs: Attention 👋
and removed
Needs: Author Feedback
labels
…Async-as-Unsupported-browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we can remove the repetitive
pragma warning disable CA1416