use some pattern matching #6045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Jul 16, 2025
src/Analyzers/MSTest.Analyzers.CodeFixes/AvoidExpectedExceptionAttributeFixer.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jul 16, 2025
src/Analyzers/MSTest.Analyzers/TestContextShouldBeValidAnalyzer.cs
Outdated
Show resolved
Hide resolved
Youssef1313
previously approved these changes
Jul 16, 2025
# Conflicts: # src/Analyzers/MSTest.SourceGeneration/Helpers/SystemPolyfills.cs # src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Youssef1313
previously approved these changes
Jul 16, 2025
|
@SimonCropp what's the proper fix for: |
Evangelink
reviewed
Jul 18, 2025
src/Analyzers/MSTest.SourceGeneration/MSTest.SourceGeneration.csproj
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jul 18, 2025
| @@ -46,6 +48,7 @@ This package provides the C# source generators for MSTest test framework.]]> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all" /> | |||
| <!-- Analyzers to help write analyzers/generators --> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" PrivateAssets="all" /> | |||
| <PackageReference Include="Polyfill" PrivateAssets="all" /> | |||
There was a problem hiding this comment.
This one is likely to cause us issues, if not now, later. This project targets netstandard2.0 and has IVT exposed to test project (not netstandard2.0). So likely going to cause us issues, unless either IVT is removed and make the needed members public, or EmbeddedAttribute is used.
|
Closing this one too for now, we need to wait for the |
auto-merge was automatically disabled
July 22, 2025 10:00
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is purely a personal preference