[UITestMethod] should invoke test method with null#1045
Merged
Haplois merged 1 commit intomicrosoft:mainfrom Feb 23, 2022
Merged
[UITestMethod] should invoke test method with null#1045Haplois merged 1 commit intomicrosoft:mainfrom
Haplois merged 1 commit intomicrosoft:mainfrom
Conversation
Haplois
approved these changes
Feb 23, 2022
cvpoienaru
pushed a commit
to cvpoienaru/testfx
that referenced
this pull request
Apr 4, 2022
nohwnd
pushed a commit
that referenced
this pull request
Apr 7, 2022
) (#1061) Co-authored-by: Nandin Borjigin <nandiin@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changed the argument of
ITestMethodinvocation call inUITestMethodfrom an empty array to null.Why
DataRowAttributeand other data driven testing depends on the argument being null to inject the parameters from data source or data row. Sending an empty array intoITestMethod.Invokebreaks this mechanism.There is no existing test for these two attributes, thus not tests are updated.