Skip to content

Fix a output marks performance regression #19242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2025
Merged

Fix a output marks performance regression #19242

merged 2 commits into from
Aug 13, 2025

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Aug 13, 2025

An alternative approach for #18291. Improves perf by ~7%.

DHowett
DHowett approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever. and this only increases memory usage by, like, 16 bytes per row or something.

@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.23 Servicing Pipeline Aug 13, 2025
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.22 Servicing Pipeline Aug 13, 2025
@lhecker
Copy link
Member Author

lhecker commented Aug 13, 2025

Yeah exactly.

@lhecker lhecker merged commit 6b19d21 into main Aug 13, 2025
19 checks passed
@lhecker lhecker deleted the dev/lhecker/row-perf branch August 13, 2025 16:10
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.23 Servicing Pipeline Aug 21, 2025
DHowett pushed a commit that referenced this pull request Aug 21, 2025
@lhecker @DHowett
Fix a output marks performance regression (#19242)
829688d 
An alternative approach for #18291. Improves perf by ~7%.

(cherry picked from commit 6b19d21)
Service-Card-Id: PVTI_lADOAF3p4s4Axadtzgdm49M
Service-Version: 1.23
@DHowett DHowett moved this from Cherry Picked to Shipped in 1.23 Servicing Pipeline Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
1.22 Servicing Pipeline
Status: To Cherry Pick
1.23 Servicing Pipeline
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhecker @DHowett