Skip to content

[api-documenter] Update regex in the OfficeYamlDocumenter to be case insensitive #5257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlexJerabek
Copy link
Contributor

Summary

This PR fixes output like what's seen in this yaml file. When the term "Api" is in the description twice, the API set link isn't corrected. In this case, the "ExcelApi" string is also incorrectly changed.

image

The solution is to combine the case normalization of "Api set" and the link addition.

Details

How it was tested

Manually tested the regex against the source yaml.

Impacted documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Development

Successfully merging this pull request may close these issues.

2 participants