ci: move "NPM Publish (Dry Run)" to Github Actions #2532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 1, 2025
Saadnajmi
commented
Jul 3, 2025
| if (adoSourceBranchName) { | ||
| return adoSourceBranchName.replace(/^refs\/heads\//, ""); | ||
| // Azure DevOps Pipelines | ||
| if (process.env["TF_BUILD"] === "True") { |
There was a problem hiding this comment.
Will need to check this..
amgleitman
approved these changes
Jul 4, 2025
Saadnajmi
added a commit
that referenced
this pull request
Jul 7, 2025
- Backport of #2532 - Backport of #2436 (the former change depends on it) - Adds a version plan to publish a new release --------- Co-authored-by: Tommy Nguyen <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Jul 7, 2025
- Backport of #2532 - Backport of #2436 (the former change depends on it) - Adds a version plan to publish a new release --------- Co-authored-by: Tommy Nguyen <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Jul 7, 2025
- Backport of #2532 - Backport of #2436 (the former change depends on it) - Adds a version plan to publish a new release --------- Co-authored-by: Tommy Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Our NX release dry run job depends on a read-only GitHub token (I'm pretty sure...) which is hard to get with Azure Pipelines. Let's move the job to Github Actions. In the process, I also updated both the dry run and the Azure Pipelines publish job to read our publish tag directly from
nx.jsoninstead of having it set in YAML. Not sure why we didn't do that earlier.. I'll have to go check those PRs to see if we had a strong reason.Test Plan:
CI should pass