Fix completions for import and exports #2640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minestarks
force-pushed
the
minestarks/completions-imports
branch
from
2eb1cc8 to
1a47bab
Compare
minestarks
requested review from
billti,
idavis,
ScottCarda-MS and
swernli
as code owners
|
Change in memory usage detected by benchmark. Memory Report for 1bd3bb8
|
minestarks
changed the title
|
Change in memory usage detected by benchmark. Memory Report for 7b4173c
|
orpuente-MS
reviewed
Aug 11, 2025
orpuente-MS
approved these changes
Aug 11, 2025
|
Change in memory usage detected by benchmark. Memory Report for f97474b
|
|
Change in memory usage detected by benchmark. Memory Report for 1056998
|
ScottCarda-MS
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the completion logic for imports and exports to be more robust and accurate.
The completion provider in the language service (
global_items.rs) has been rewritten to leverage theGlobalScopeandLocalsstructs already available from the resolver. This allows completions to use the same "view" as the name resolution code, rather than trying to recreate it by manually analyzing imports, enumerating items, etc. All of that work has already been done by the resolver.The previous implementation for completions had difficulty handling more complex import and export scenarios, such as items re-exported from dependencies or items under aliased namespaces. This could lead to incomplete or incorrect suggestions. The new approach provides a more solid foundation, giving the language service a complete and accurate view of all available symbols.
Fixes #2142