Skip to content

Fix off-by-one error in stack traces by making line and column numbers 1-based for user display #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 13, 2025
Merged

Fix off-by-one error in stack traces by making line and column numbers 1-based for user display #2628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6a710e8
Initial plan
Copilot Jul 24, 2025
5d52006
Initial analysis and test for off-by-one error in stack traces
Copilot Jul 24, 2025
7f34561
Fix off-by-one error in stack traces by making line numbers 1-based f…
Copilot Jul 24, 2025
62e0d53
Add 1 to column position and remove extra tests per feedback
Copilot Jul 30, 2025
93477e9
Revert test file and regenerate snapshots with correct 1-based line/c…
Copilot Aug 6, 2025
1491731
Revert test file to original state and update existing test expectati…
Copilot Aug 8, 2025
3a60a4d
Merge origin/main into fix branch and resolve conflicts
Copilot Aug 8, 2025
e00c183
Merge main and update test snapshots with correct 1-based line/column…
Copilot Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/compiler/qsc/src/interpret/debug.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ pub(crate) fn format_call_stack(
trace,
" in {}:{}:{}",
name.unwrap_or("<expression>".to_string()),
pos.line,
pos.column,
pos.line + 1,
pos.column + 1,
)
.expect("writing to string should succeed");

Expand Down
14 changes: 7 additions & 7 deletions source/compiler/qsc/src/interpret/debug/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ fn stack_traces_can_cross_eval_session_and_file_boundaries() {
expect![[r#"
Error: division by zero
Call stack:
at Adjoint Test.C in 1.qs:10:12
at Adjoint Test.B in 1.qs:3:12
at Adjoint Test2.A in 2.qs:4:12
at Z in line_0:0:34
at Adjoint Test.C in 1.qs:11:13
at Adjoint Test.B in 1.qs:4:13
at Adjoint Test2.A in 2.qs:5:13
at Z in line_0:1:35
"#]]
.assert_eq(stack_trace);
}
Expand Down Expand Up @@ -165,9 +165,9 @@ fn stack_traces_can_cross_file_and_entry_boundaries() {
expect![[r#"
Error: division by zero
Call stack:
at Adjoint Test.C in 1.qs:10:12
at Adjoint Test.B in 1.qs:3:12
at Adjoint Test2.A in 2.qs:4:12
at Adjoint Test.C in 1.qs:11:13
at Adjoint Test.B in 1.qs:4:13
at Adjoint Test2.A in 2.qs:5:13
"#]]
.assert_eq(stack_trace);
}
Expand Down
Loading