Remove implicit modifier handling during OpenQASM lowering #2529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original implementation of the OpenQASM compiler, gates with implicit modifiers needed to be specially handled by redefining them as their unmodiefied variants and collecting the modifier. For example,
ch
would be converted toh
with actrl(1)
modifier and would be used to build up the gate call with the additional explicit modifiers.With the introduction of the
Std.OpenQASM
library, we can now call those gates directly without needing to decompose them. This also cleans up error messages as any errors would have been associated with the unmodified gate name prior.