Fix histogram escape key handling in VS Code extension #2468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users clicked "Histogram" in VS Code and were prompted for the number of shots, pressing Escape did not cancel the operation as expected. Instead, the histogram was still displayed with a default value of 100 shots.
Root Cause
The issue was in the
handleShowHistogram
function inwebviewPanel.ts
. The code used a fallback pattern that prevented proper escape key detection:When a user pressed Escape,
showInputBox()
returnedundefined
, but the|| "100"
fallback immediately assigned "100" tonumberOfShots
, making the subsequentundefined
check never true.Solution
Removed the problematic fallback and properly checked for escape key before using the input value:
This pattern matches how escape key handling is implemented correctly in other parts of the codebase, such as the Azure workspace actions and the resource estimation commands.
Testing
Fixes #1872.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com
node ./test/runTests.mjs
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.